[GR-67626] Fast-path for builtin reads and get/set attribute operations.#982
Open
graalvmbot wants to merge 4 commits into
Open
[GR-67626] Fast-path for builtin reads and get/set attribute operations.#982graalvmbot wants to merge 4 commits into
graalvmbot wants to merge 4 commits into
Conversation
c4b29b4 to
d439d53
Compare
d439d53 to
73a9cec
Compare
…ransition to cached. Traceback collection counted frames during exception unwinding, but did not mark them as escaped. In uncached execution, we had the PFrame.Reference links unconditionally, so this worked when it happened then, and we marked the root as needing the PFrame.Reference link, so on later cached calls we have them. But if we raise and escape the frame for the very first time when already cached we did not preserve the f_back chain and could not reconstruct it properly later. This change makes the frames that belong to a traceback mark their current PFrame.Reference as escaped while the exception is unwinding and the VirtualFrame is thus still on the stack. The CalleeContext#exit logic then materializes the frame and propagates to caller frames and this preserves the f_back chain. This can be triggered by forcing immediately cached execution, but a regression test covers the case where functions first transition to cached execution without raising, then later raises after some time (presumably after we transitioned to cached) and inspect traceback backrefs.
47661af to
88a5489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.